| To: | Andreas Schwab <schwab@xxxxxxx> |
|---|---|
| Subject: | Re: Parenthesize macros in xfs |
| From: | Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> |
| Date: | Sun, 26 Mar 2006 11:26:41 +0200 (MEST) |
| Cc: | Nathan Scott <nathans@xxxxxxx>, linux-xfs@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> |
| In-reply-to: | <jewtei1434.fsf@xxxxxxxxxxxxx> |
| References: | <Pine.LNX.4.61.0603202207310.20060@xxxxxxxxxxxxxxx> <20060321082327.B653275@xxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0603202239110.11933@xxxxxxxxxxxxxxx> <20060321084619.E653275@xxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0603252232570.18484@xxxxxxxxxxxxxxx> <je1wwq2lqn.fsf@xxxxxxxxxxxxx> <Pine.LNX.4.61.0603260023070.12891@xxxxxxxxxxxxxxx> <jewtei1434.fsf@xxxxxxxxxxxxx> |
| Sender: | linux-xfs-bounce@xxxxxxxxxxx |
>>>> + swapfunc(a, b, es, swaptype) \ >>>> +} while(0) >>> ^^ >>>Missing semicolon. >> >> It was missing before too. ;) > >No, previously it was provided at the call site. Bad habit IMO. It does not hurt to provide it in both the macro and the call site, GCC can handle empty instructions. Jan Engelhardt -- |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: How many people regularly defrag their XFS filesystems?, Federico Sevilla III |
|---|---|
| Next by Date: | Re: How many people regularly defrag their XFS filesystems?, KELEMEN Peter |
| Previous by Thread: | Re: Parenthesize macros in xfs, Andreas Schwab |
| Next by Thread: | Re: Parenthesize macros in xfs, Andreas Schwab |
| Indexes: | [Date] [Thread] [Top] [All Lists] |