xfs
[Top] [All Lists]

Re: [RFC] Badness in __mutex_unlock_slowpath with XFS stress tests

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: [RFC] Badness in __mutex_unlock_slowpath with XFS stress tests
From: Adrian Bunk <bunk@xxxxxxxxx>
Date: Fri, 17 Mar 2006 18:22:10 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Suzuki <suzuki@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, "linux-aio kvack.org" <linux-aio@xxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, suparna <suparna@xxxxxxxxxx>, akpm@xxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <20060310005020.GF1135@frodo>
References: <440FDF3E.8060400@xxxxxxxxxx> <20060309120306.GA26682@xxxxxxxxxxxxx> <20060309223042.GC1135@frodo> <20060309224219.GA6709@xxxxxxxxxxxxx> <20060309231422.GD1135@frodo> <20060310005020.GF1135@frodo>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.11+cvs20060126
On Fri, Mar 10, 2006 at 11:50:20AM +1100, Nathan Scott wrote:
> On Fri, Mar 10, 2006 at 10:14:22AM +1100, Nathan Scott wrote:
> > On Thu, Mar 09, 2006 at 10:42:19PM +0000, Christoph Hellwig wrote:
> > > On Fri, Mar 10, 2006 at 09:30:42AM +1100, Nathan Scott wrote:
> > > > Not for reads AFAICT - __generic_file_aio_read + own-locking
> > > > should always have released i_mutex at the end of the direct
> > > > read - are you thinking of writes or have I missed something?
> > > 
> > > if an error occurs before a_ops->direct_IO is called 
> > > __generic_file_aio_read
> > > will return with i_mutex still locked.  Note that checking for negative
> > > return values is not enough as __blockdev_direct_IO can return errors
> > > aswell.
> > 
> > *groan* - right you are.  Another option may be to have the
> > generic dio+own-locking case reacquire i_mutex if it drops
> > it, before returning... thoughts?  Seems alot less invasive
> > than the filemap.c code dup'ing thing.
> 
> Something like this (works OK for me)...

Is this 2.6.16 material?

> cheers.
> Nathan
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


<Prev in Thread] Current Thread [Next in Thread>