| To: | Nathan Scott <nathans@xxxxxxx> |
|---|---|
| Subject: | Re: Parenthesize macros in xfs |
| From: | Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> |
| Date: | Mon, 20 Mar 2006 22:39:45 +0100 (MET) |
| Cc: | linux-xfs@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> |
| In-reply-to: | <20060321082327.B653275@wobbly.melbourne.sgi.com> |
| References: | <Pine.LNX.4.61.0603202207310.20060@yvahk01.tjqt.qr> <20060321082327.B653275@wobbly.melbourne.sgi.com> |
| Sender: | linux-xfs-bounce@xxxxxxxxxxx |
>> Hello xfs list, > >Hi Jan, > >> while browsing through the xfs/linux source, I noticed that many macros do >> not do proper bracing. I have started to cook up a patch, but would like >> feedback first before I continue for nothing. >> It goes like this: >> ... > >That looks fine. Please be sure to work on the -mm tree or on >CVS on oss.sgi.com, so as to reduce your level of patch conflict. > Hm, would not it even be better to make them 'static inline' functions? Jan Engelhardt -- | Software Engineer and Linux/Unix Network Administrator |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | TAKE 947420 - Fixing the conflict between DIO write and truncate, Yingping Lu |
|---|---|
| Next by Date: | Re: Parenthesize macros in xfs, Nathan Scott |
| Previous by Thread: | Re: Parenthesize macros in xfs, Nathan Scott |
| Next by Thread: | Re: Parenthesize macros in xfs, Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |