xfs
[Top] [All Lists]

Re: Patch to fix segmentation fault in libattr

To: Simon Munton <simon@xxxxxxxxxxxxxxxxxx>
Subject: Re: Patch to fix segmentation fault in libattr
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Tue, 21 Feb 2006 16:55:26 -0800
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <200602212219.59512.simon@xxxxxxxxxxxxxxxxxx>
References: <200602212219.59512.simon@xxxxxxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
On Tue, Feb 21, 2006 at 10:19:59PM +0000, Simon Munton wrote:

> I tracked the problem down to the attr_list function in
> libattr.c. This contains a loop that uses the value from the
> listxattr call to determine when the loop finishes. However, this
> value is overwritten in the loop by the call to getxattr.

Wouldn't it be better to also rename one of the variables so there is
no confusion?  You could also try building with -Wshadow after that.


<Prev in Thread] Current Thread [Next in Thread>