xfs
[Top] [All Lists]

bad inode causes xfs_bulkstat to loop

To: linux-xfs@xxxxxxxxxxx
Subject: bad inode causes xfs_bulkstat to loop
From: Roger Willcocks <willcor@xxxxxxxxx>
Date: Thu, 2 Feb 2006 15:02:21 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=oflh+0WTUT9ASnxzqEDOmrLxfUvOPv82YfKW/c7ewG8iOdN1CTt5rCIGWUnCq70JX5t6WVin2QCCyaZjMIRe0ThVmiLfVRZgcil7I+Xj2zSD7i0NHeiXTQaJfm8/rX7Av3US31lJsavVebE2DggyQqAC25uxTQdUsiPLDoREUZI=
Sender: linux-xfs-bounce@xxxxxxxxxxx
xfs_bulkstat can get into a tight loop if there are bad inodes. (Seen
running xfs_fsr - it took 100% of one cpu on a dual cpu machine.
Worked fine after xfs_repair.)

It looks like the 'break' caused by the xfs_itobp call in xfs_bulkstat
returning an error means no terminating condition is set for the outer
loop.

The break looks slightly suspicious anyway - shouldn't the inode
simply be ignored? (Ref. the comment at the top of
xfs_bulkstat_single).

Perhaps add 'ubleft = 0; rval = error;' before the break (as happens
if the formatter returns 'bulkstat_rv_giveup') ?

--
Rger


<Prev in Thread] Current Thread [Next in Thread>