Re: XFS mount alignment patch

[David Chinner <dgc@xxxxxxx>]

On Sat, Jan 07, 2006 at 08:03:58PM +0530, Alok Kataria wrote:
> On Fri, 2006-01-06 at 21:48, Christoph Hellwig wrote:
> > Any chance you could archive the alignment without the use of anonymous
> > structs?  XFS still needs to compile with compilers that don't support
> > this (non-ANIS C) feature, and it looks quite ugly.
> > 
> 
> This version doesn't use anonymous structs. Please check if this could be 
> applied.

Do you have any benchmark numbers for CPU usage or performance
improvement with this patch?

I have experimented with this sort of change in the past and seen
no measurable benefit when XFS has been CPU bound rather than
disk I/O bound.

Cheers,

Dave.
-- 
Dave Chinner
R&D Software Enginner
SGI Australian Software Group