xfs
[Top] [All Lists]

Re: xfs_repair missing freetab entry

To: Masanori TSUDA <tsuda@xxxxxxxxxxxxxx>
Subject: Re: xfs_repair missing freetab entry
From: Nathan Scott <nathans@xxxxxxx>
Date: Thu, 15 Dec 2005 11:32:52 +1100
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <5BC600A7E4FFC8tsuda@xxxxxxxxxxxxxx>
References: <5BC600A7E4FFC8tsuda@xxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.3i
Hi there,

On Wed, Dec 14, 2005 at 09:14:12PM +0900, Masanori TSUDA wrote:
> I encountered a problem that xfs_repair outputs the corruption
> message below.
> 
>   (snip)
>   Phase 6 - check inode connectivity...
>           - traversing filesystem starting at / ...
>   missing freetab entry 2039 for directory inode 131
>           - traversal finished ...
>           - traversing all unattached subtrees ...
>           - traversals finished ...
>           - moving disconnected inodes to lost+found ...
>   (snip)
> ...
> When the count of valid entries in the intermediate freespace block
> of the directory is below 2040(XFS_DIR2_MAX_FREE_BESTS(mp)) or the
> intermediate freespace block is hole,
> xfs_repair outputs "missing freetab entry...".
> But its filesystem is correct. Because kernel space functions
> xfs_dir2_node_addname_int(), xfs_dir2_leafn_remove() make its
> state.

*nod*

> I made patch to solve this problem.
> The xfs_preair added the patch was running with no corruption
> messages.

Nice work - thanks.

> Could you please comment the attached patch.

That looks correct.  I've created an XFS regression test from
your test case (test 110) - and I'll get this fix merged soon.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>