On Thu, Dec 01, 2005 at 11:20:21AM +0000, Christoph Hellwig wrote:
> On Thu, Dec 01, 2005 at 08:27:09AM +1100, Nathan Scott wrote:
> > | I had actually suggested that the patch removing the old post hooks from
> > | the VFS be deferred until after 2.6.14 to avoid breaking the unconverted
> > | filesystems while still allowing the converted ones to use the new
> > | support, but it seems my request was misunderstood. We could possibly
> > | ask to have the removal patch reverted
> >
> > Please do that, we are not going to be able to fix this quickly in
> > XFS, as there is an underlying issue here that makes this alot more
> > tricky to resolve in XFS. But we are aware of the problem and do
> > plan to fix it, so if you could cater for XFS/SE-Linux users for a
> > little while longer, that would be great.
>
> No, reverting this is bogus. If you really want to support selinux without
> real transaction support
Well, I mainly want to not cause a huge regression for those
people who were using it in the stable kernel series.
> just implement the new inode initialization method
> without doing adding the labeling to the transaction.
Hmmm ... if its that simple, then that should have been done
for reiserfs and XFS before this change was merged at all,
surely? That would've kept the old (albeit not quite correct)
behaviour without the regression, and given ample opportunity
for the remaining filesystems to get properly fixed up... no?
thanks.
--
Nathan
|