xfs
[Top] [All Lists]

Re: xfsprogs patch 2

To: Craig Rodrigues <rodrigc@xxxxxxxxxxxxxx>
Subject: Re: xfsprogs patch 2
From: Nathan Scott <nathans@xxxxxxx>
Date: Sat, 8 Oct 2005 09:54:52 +1000
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20051007212724.GA99806@xxxxxxxxxxxxxx>; from rodrigc@xxxxxxxxxxxxxx on Fri, Oct 07, 2005 at 05:27:24PM -0400
References: <20051007212724.GA99806@xxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Fri, Oct 07, 2005 at 05:27:24PM -0400, Craig Rodrigues wrote:
> ...
> group on Linux and IRIX.  Inside install-sh, we have:
> 
> OWNER=`id -u`
> GROUP=`id -g`
> ...
> So, if you don't override these values on the command-line while
> invoking install-sh, they default to the values of the
> user and group who typed 'make install'.  This seems to be a reasonable
> convention to follow (and seems to be what other packages do).

> To avoid this problem on other platforms, I recommend removing
> PKG_USER and PKG_GROUP from the autoconf files, and just
> use the OWNER and GROUP of the user that typed 'make install'.

Well, someone might be relying on this now - why not just fix:

> Index: m4/package_globals.m4
>  
> -    PKG_USER=${INSTALL_USER:-'root'}
> -    pkg_user="$PKG_USER"
> -    AC_SUBST(pkg_user)
> -
> -    PKG_GROUP=${INSTALL_GROUP:-'root'}
> -    pkg_group="$PKG_GROUP"
> -    AC_SUBST(pkg_group)
> -
>      pkg_distribution=`uname -s`
>      test -z "$DISTRIBUTION" || pkg_distribution="$DISTRIBUTION"
>      AC_SUBST(pkg_distribution)

...the first two there to use 'id -u' and 'id -g'?  (like the
third chunk does for 'uname -s').

thanks.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>