xfs
[Top] [All Lists]

Re: xfsprogs patch 1

To: Craig Rodrigues <rodrigc@xxxxxxxxxxxxxx>
Subject: Re: xfsprogs patch 1
From: Nathan Scott <nathans@xxxxxxx>
Date: Sat, 8 Oct 2005 06:31:45 +1000
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20051007185443.GA57747@crodrigues.org>; from rodrigc@crodrigues.org on Fri, Oct 07, 2005 at 02:54:43PM -0400
References: <20051007185443.GA57747@crodrigues.org>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Fri, Oct 07, 2005 at 02:54:43PM -0400, Craig Rodrigues wrote:
> Hi,
> 
> Why is -O1 hardcoded in the CFLAGS for xfsprogs?
> Since there already is a variable $(OPTIMIZER), can't
> we just remove it?  In the FreeBSD port for xfsprogs,
> I remove it, since most FreeBSD ports are compiled with a
> default optimization flag (-O2).

We should probably fix this up now - the reason was about 4 / 5
years ago, some old version of gcc miscompiled xfs_db at -O2 and
caused segfaults.  But, its likely noone is using that old a gcc
anymore, so we can safely remove this hack now I think.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>