xfs
[Top] [All Lists]

TAKE 943266 - save some stack in xfs_iomap_write_direct

To: sgi.bugs.xfs@xxxxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
Subject: TAKE 943266 - save some stack in xfs_iomap_write_direct
From: Eric Sandeen <sandeen@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 26 Sep 2005 10:01:38 -0500
Sender: linux-xfs-bounce@xxxxxxxxxxx
xfs_iomap_write_direct puts XFS_WRITE_IMAPS (4) xfs_bmbt_irec_t's on the stack,
but only ever uses one.  It also does some calculations that it throws away.

Clean this up a bit... and save 80 bytes of stack in this function in the
process :)

Remove dead code in xfs_iomap_write_direct; save some stack


Date:  Mon Sep 26 08:00:47 PDT 2005
Workarea:  penguin.americas.sgi.com:/src/eric/xfs-trees/xfs-GUT-clean
Inspected by:  nathans

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/xfs-kern/xfs-linux


Modid:  xfs-linux:xfs-kern:199750a
xfs_iomap.c - 1.39 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_iomap.c.diff?r1=text&tr1=1.39&r2=text&tr2=1.38&f=h
        - Don't put more imaps on the stack than we're going to use,
          take out some unused vars & calculations done on them



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 943266 - save some stack in xfs_iomap_write_direct, Eric Sandeen <=