| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: Warnings when compiling xfs_macros.c |
| From: | Craig Rodrigues <rodrigc@xxxxxxxxxxxxxx> |
| Date: | Thu, 8 Sep 2005 11:25:13 -0400 |
| Cc: | linux-xfs@xxxxxxxxxxx |
| In-reply-to: | <20050908105745.GA5847@xxxxxxxxxxxxx> |
| References: | <20050907174535.GA1850@xxxxxxxxxxxxxx> <20050907182059.GA13074@xxxxxxxxxxxxx> <20050907184542.GA2316@xxxxxxxxxxxxxx> <20050908105745.GA5847@xxxxxxxxxxxxx> |
| Sender: | linux-xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.9i |
On Thu, Sep 08, 2005 at 11:57:45AM +0100, Christoph Hellwig wrote: > That was about changing them to functions, which is a) an intrusive > change and b) very debatable. Just leave the macros and remove the > whole expand the macros to out of line functions alternatively logic. > If one of them is to big we can change it to a function call later > more easily after this initial change. I don't really follow what you are looking for. Can you take one or two functions in xfs_macros.c and post an example patch? -- Craig Rodrigues rodrigc@xxxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Warnings when compiling xfs_macros.c, Christoph Hellwig |
|---|---|
| Next by Date: | xfs and an iscsi hba, Matthew Kent |
| Previous by Thread: | Re: Warnings when compiling xfs_macros.c, Christoph Hellwig |
| Next by Thread: | XFS and LVM2 snapshot with external log problem, Mario Becroft |
| Indexes: | [Date] [Thread] [Top] [All Lists] |