Re: Warnings when compiling xfs_macros.c

[Craig Rodrigues <rodrigc@xxxxxxxxxxxxxx>]

On Wed, Sep 07, 2005 at 07:21:00PM +0100, Christoph Hellwig wrote:
> xfs_macros.c is a mess.  If you want to do a service to everyone
> kill it and the surrounding machinery and just leave the macros,
> without the out of line instances.

I don't like xfs_macros.c either, but my understanding
was that it still needs to be around, so as not to diverge
from the Irix code.  At least that is my understanding
based on reading this thread:
http://oss.sgi.com/archives/linux-xfs/2004-01/msg00187.html

My proposed patch would not disturb the status quo (however distasteful),
and get things to compile with -Wmissing-prototypes, which is
used in the FreeBSD kernel compilation flags.

-- 
Craig Rodrigues        
rodrigc@xxxxxxxxxxxxxx