On Wed, Sep 07, 2005 at 02:45:42PM -0400, Craig Rodrigues wrote:
> On Wed, Sep 07, 2005 at 07:21:00PM +0100, Christoph Hellwig wrote:
> > xfs_macros.c is a mess. If you want to do a service to everyone
> > kill it and the surrounding machinery and just leave the macros,
> > without the out of line instances.
>
> I don't like xfs_macros.c either, but my understanding
> was that it still needs to be around, so as not to diverge
> from the Irix code. At least that is my understanding
> based on reading this thread:
> http://oss.sgi.com/archives/linux-xfs/2004-01/msg00187.html
That was about changing them to functions, which is a) an intrusive
change and b) very debatable. Just leave the macros and remove the
whole expand the macros to out of line functions alternatively logic.
If one of them is to big we can change it to a function call later
more easily after this initial change.
|