xfs
[Top] [All Lists]

TAKE 940491 - sb_qflags are not reset after mounting/unmounting with _no

To: linux-xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 940491 - sb_qflags are not reset after mounting/unmounting with _no_ quotas
From: Timothy Shimmin <tes@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 4 Aug 2005 16:50:00 +1000 (EST)
Sender: linux-xfs-bounce@xxxxxxxxxxx
Need to be able to reset sb_qflags if not mounting with quotas,
having previously mounted with quotas.

What this means is that if one mounts with quotas, does stuff and
then unmounts. Then mounts without quotas, does stuff and then unmounts.
Then decides to turn quotas back on and mounts with quotas.
What is supposed to happen is that a quotacheck is redone on the
filesystem - to get the quota information back up to date.
Without this fix, however, this won't happen because the sb_qflags
were not being reset on a no quota mount and so it won't tell
that it had previously been mounted without quotas.

--Tim

Date:  Thu Aug  4 16:41:05 AEST 2005
Workarea:  snort.melbourne.sgi.com:/home/tes/isms/xfs-linux-test
Inspected by:  nathans@xxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/xfs-kern/xfs-linux-melb


Modid:  xfs-linux-melb:xfs-kern:23388a
xfs_qmops.c - 1.11 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_qmops.c.diff?r1=text&tr1=1.11&r2=text&tr2=1.10&f=h
        - Add xfs_mount_reset_sbqflags from xfs_qm_bhv.c since we need it
          for the non-quota case and will use it here. 
          Add a quota stub function for xfs_qminit called xfs_noquota_init()
          which does the qflags resetting if necessary.

xfs_quota.h - 1.40 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_quota.h.diff?r1=text&tr1=1.40&r2=text&tr2=1.39&f=h
        - Add some QUOTA macros from xfs_qm.h .

quota/xfs_qm_bhv.c - 1.12 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/quota/xfs_qm_bhv.c.diff?r1=text&tr1=1.12&r2=text&tr2=1.11&f=h
        - Remove xfs_mount_reset_sbqflags since it is moving to xfs_qmops.c .

quota/xfs_dquot.h - 1.8 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/quota/xfs_dquot.h.diff?r1=text&tr1=1.8&r2=text&tr2=1.7&f=h
        - Remove some QUOTA macros and put them in xfs_quota.h for
          use in xfs_qmops.c .

quota/xfs_qm.h - 1.11 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/quota/xfs_qm.h.diff?r1=text&tr1=1.11&r2=text&tr2=1.10&f=h
        - Remove xfs_mount_reset_sbqflags() proto since the function
          is moving to xfs_qm.c and the proto to xfs_quota.h .

quota/xfs_qm.c - 1.25 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/quota/xfs_qm.c.diff?r1=text&tr1=1.25&r2=text&tr2=1.24&f=h
        - Remove resetting of qflags here and move it to xfs_qmops.c .



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 940491 - sb_qflags are not reset after mounting/unmounting with _no_ quotas, Timothy Shimmin <=