xfs
[Top] [All Lists]

Re: XFS corruption on move from xscale to i686

To: Yura Pakhuchiy <pakhuchiy@xxxxxxxxx>
Subject: Re: XFS corruption on move from xscale to i686
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 14 Jul 2005 15:38:30 +0100
Cc: Nathan Scott <nathans@xxxxxxx>, linux-xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tibor@xxxxxxxxxxx, pakhuchiy@xxxxxxxx
In-reply-to: <60868aed050714065047e3aaec@xxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Yura Pakhuchiy <pakhuchiy@xxxxxxxxx>, Nathan Scott <nathans@xxxxxxx>, linux-xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tibor@xxxxxxxxxxx, pakhuchiy@xxxxxxxx
References: <1120756552.5298.10.camel@xxxxxxxxxxxxxxxxxxxxxxx> <20050708042146.GA1679@frodo> <60868aed0507130822c2e9e97@xxxxxxxxxxxxxx> <20050714012048.GB937@frodo> <60868aed050714065047e3aaec@xxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Thu, Jul 14, 2005 at 04:50:01PM +0300, Yura Pakhuchiy wrote:
> 2005/7/14, Nathan Scott <nathans@xxxxxxx>:
> > On Wed, Jul 13, 2005 at 06:22:28PM +0300, Yura Pakhuchiy wrote:
> > > I found patch by Greg Ungreger to fix this problem, but why it's still
> > > not in mainline? Or it's a gcc problem and should be fixed by gcc folks?
> > 
> > Yes, IIRC the patch was incorrect for other platforms, and it sure
> > looked like an arm-specific gcc problem (this was ages back, so
> > perhaps its fixed by now).
> 
> AFAIR gcc-3.4.3 was released after this conversation take place at linux-xfs,
> maybe add something like this:
> 
> #ifdef XSCALE
>     /* We need this because some gcc versions for xscale are broken. */
>     [patched version here]
> #else
>     [original version here]
> #endif

no, just fix your compiler or let the gcc folks do it.  Did anyone of
the arm folks ever open a PR at the gcc bugzilla with a reproduced
testcase?  You're never get your compiler fixed with that attitude.


<Prev in Thread] Current Thread [Next in Thread>