xfs
[Top] [All Lists]

Re: [xfs-masters] [patch 2/2] fs/xfs_super: replace schedule_timeout() w

To: domen@xxxxxxxxxxxx, nacc@xxxxxxxxxx
Subject: Re: [xfs-masters] [patch 2/2] fs/xfs_super: replace schedule_timeout() with msleep_interruptible()
From: Nathan Scott <nathans@xxxxxxx>
Date: Tue, 8 Mar 2005 11:01:14 +1100
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20050306104000.A71391F204@xxxxxxxxxxxxxxxxxxx>
References: <20050306104000.A71391F204@xxxxxxxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.3i
On Sun, Mar 06, 2005 at 11:40:00AM +0100, domen@xxxxxxxxxxxx wrote:
> 
> Use msleep_interruptible() instead of schedule_timeout(). The
> current code is not wrong; however a change to msleep_interruptible() has two
> major benefits: 1) consistency across the kernel and 2) uses human-sensible 
> time
> units (msecs). Change the units of timeleft appropriately to msecs.
> ...
> -     timeleft = (xfs_syncd_centisecs * HZ) / 100;
> +     timeleft = xfs_syncd_centisecs * 10;

Hmm... can you explain that a bit more?  These are already in
"human-sensible" units - centisecs (ala. pdflush), your patch
seems to break this, and changes a user-visible interface too.

thanks.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>