xfs
[Top] [All Lists]

DMAPI & NOSPACE data corruption.

To: linux-xfs@xxxxxxxxxxx
Subject: DMAPI & NOSPACE data corruption.
From: Kenji Munakata <munaken@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 28 Feb 2005 12:37:13 +0900
Sender: linux-xfs-bounce@xxxxxxxxxxx
Hi there,

I found that data & size corrupting when the ENOSPC(with DMAPI) retrial 
succeeds.
It seems that data offset is not reset at retry.
following patches are appended. 

--- xfs_lrw.c.ORG       2005-02-28 11:56:18.405763312 +0900
+++ xfs_lrw.c   2005-02-28 11:57:07.543293272 +0900
@@ -862,24 +862,25 @@
        if ((ret == -ENOSPC) &&
            DM_EVENT_ENABLED(vp->v_vfsp, xip, DM_EVENT_NOSPACE) &&
            !(ioflags & IO_INVIS)) {
 
                xfs_rwunlock(bdp, locktype);
                error = XFS_SEND_NAMESP(xip->i_mount, DM_EVENT_NOSPACE, vp,
                                DM_RIGHT_NULL, vp, DM_RIGHT_NULL, NULL, NULL,
                                0, 0, 0); /* Delay flag intentionally  unused */
                if (error)
                        goto out_unlock_isem;
                xfs_rwlock(bdp, locktype);
                pos = xip->i_d.di_size;
+               ret = 0;
                goto retry;
        }

Regards,
Kenji MUNAKATA


<Prev in Thread] Current Thread [Next in Thread>