xfs
[Top] [All Lists]

Re: Advice sought on how to lock multiple pages in ->prepare_write and -

To: Bryan Henderson <hbryan@xxxxxxxxxx>
Subject: Re: Advice sought on how to lock multiple pages in ->prepare_write and ->writepage
From: Matthew Wilcox <matthew@xxxxxx>
Date: Tue, 1 Feb 2005 01:29:20 +0000
Cc: Nathan Scott <nathans@xxxxxxx>, Anton Altaparmakov <aia21@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <OFD4DAAE59.6685BB61-ON88256F97.007D2911-88256F97.007DCD5B@us.ibm.com>
References: <20050128050614.GC1799@frodo> <OFD4DAAE59.6685BB61-ON88256F97.007D2911-88256F97.007DCD5B@us.ibm.com>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, Jan 28, 2005 at 02:53:41PM -0800, Bryan Henderson wrote:
> >Just putting up my hand to say "yeah, us too" - we could also make
> >use of that functionality, so we can grok existing XFS filesystems
> >that have blocksizes larger than the page size.
> 
> IBM Storage Tank has block size > page size and has the same problem. This 
> is one of several ways that Storage Tank isn't generic enough to use 
> generic_file_write() and generic_file_read(), so it doesn't.  That's not a 
> terrible way to go, by the way.  At some point, making the generic 
> interface complex enough to handle every possible filesystem becomes worse 
> than every filesystem driver having its own code.

That's certainly true; but it might make sense to write a
multipage_file_read() and multipage_file_write() that can be shared
between the filesystems that do need this complexity.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain


<Prev in Thread] Current Thread [Next in Thread>