xfs
[Top] [All Lists]

[PATCH 11/40] fs/xfs_buf: replace schedule_timeout() with msleep()

To: xfs-master@xxxxxxxxxxx, nathans@xxxxxxx
Subject: [PATCH 11/40] fs/xfs_buf: replace schedule_timeout() with msleep()
From: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Date: Thu, 20 Jan 2005 11:12:29 -0800
Cc: linux-xfs@xxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxx
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
Hi,

Please consider applying.

Description: Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. The current code uses TASK_INTERRUPTIBLE, but does not check
for signals, so I believe the change to msleep() is appropriate.

Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>

--- 2.6.11-rc1-kj-v/fs/xfs/linux-2.6/xfs_buf.c  2005-01-15 16:55:41.000000000 
-0800
+++ 2.6.11-rc1-kj/fs/xfs/linux-2.6/xfs_buf.c    2005-01-18 11:09:34.000000000 
-0800
@@ -54,6 +54,7 @@
 #include <linux/suspend.h>
 #include <linux/percpu.h>
 #include <linux/blkdev.h>
+#include <linux/delay.h>
 
 #include "xfs_linux.h"
 
@@ -1689,8 +1690,7 @@ pagebuf_daemon(
                if (current->flags & PF_FREEZE)
                        refrigerator(PF_FREEZE);
 
-               set_current_state(TASK_INTERRUPTIBLE);
-               schedule_timeout((xfs_buf_timer_centisecs * HZ) / 100);
+               msleep(xfs_buf_timer_centisecs * 10);
 
                age = (xfs_buf_age_centisecs * HZ) / 100;
                spin_lock(&pbd_delwrite_lock);


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 11/40] fs/xfs_buf: replace schedule_timeout() with msleep(), Nishanth Aravamudan <=