| To: | Nathan Scott <nathans@xxxxxxx> |
|---|---|
| Subject: | Re: [2.6 patch] some XFS cleanups (fwd) |
| From: | Adrian Bunk <bunk@xxxxxxxxx> |
| Date: | Tue, 14 Dec 2004 01:06:21 +0100 |
| Cc: | Andrew Morton <akpm@xxxxxxxx>, linux-xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20041208050348.GI1611@frodo> |
| References: | <20041207193533.GG7250@xxxxxxxxx> <20041208050348.GI1611@frodo> |
| Sender: | linux-xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Wed, Dec 08, 2004 at 04:03:48PM +1100, Nathan Scott wrote:
>...
> > The patch below makes the following cleanups in the XFS code:
> > - remove the unused global function vfs_dmapiops
> > - remove some unused #define's
>
> These first changes aren't really useful; they make the DMAPI
> code more difficult to integrate and manage in our trees, for
> not-enough gain.
>...
OK, then the #define's have to stay.
Would it be OK to make vfs_dmapiops #ifdef on the DMAPI code?
> Nathan
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: Unknown Issue., Piszcz, Justin Michael |
|---|---|
| Next by Date: | Re: [2.6 patch] some XFS cleanups (fwd), Nathan Scott |
| Previous by Thread: | Re: [2.6 patch] some XFS cleanups (fwd), Nathan Scott |
| Next by Thread: | Re: [2.6 patch] some XFS cleanups (fwd), Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |