xfs
[Top] [All Lists]

[Bug 363] segfault of user-app while triggering dmapi event

To: xfs-master@xxxxxxxxxxx
Subject: [Bug 363] segfault of user-app while triggering dmapi event
From: bugzilla-daemon@xxxxxxxxxxx
Date: Fri, 1 Oct 2004 15:39:06 -0700
Sender: linux-xfs-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=363





------- Additional Comments From mmontour@xxxxxxxxxx  2004-01-10 15:39 PDT 
-------
I see a similar problem with the current linux-2.4-xfs kernel tree. I found one
issue in fs/xfs/xfs_dmapi.c xfs_dm_send_namesp_event:

        error = dm_send_namesp_event(event, vfsp ? vfsp->vfs_super: NULL,
                                    LINVFS_GET_IP(vp1), vp1_right,
                                    LINVFS_GET_IP(vp2), vp2_right,
                                    name1, name2,
                                    mode, retcode, flags);

In a CREATE event, vnode_t *vp2 is NULL. I changed the code to not call
LINVFS_GET_IP on a NULL value (using "vp2 ? LINVFS_GET_IP(vp2) : NULL"), and now
I successfully get CREATE and POSTCREATE events without any kernel oopses or
segfaults. I haven't investigated this further, so I don't know (A) if this is
correct or (B) if this same issue appears elsewhere in the code.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>
  • [Bug 363] segfault of user-app while triggering dmapi event, bugzilla-daemon <=