[Bug 364] New: Incorrect return values in linux kernel 2.6.8.1

[bugzilla-daemon@xxxxxxxxxxx]

http://oss.sgi.com/bugzilla/show_bug.cgi?id=364

           Summary: Incorrect return values in linux kernel 2.6.8.1
           Product: Linux XFS
           Version: unspecified
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: High
         Component: XFS kernel code
        AssignedTo: xfs-master@xxxxxxxxxxx
        ReportedBy: christophe.jaillet@xxxxxxxxxx


Hi, i've been looking at linux kernel code (2.6.8.1) and a few things seem to 
be strange in the /fs/xfs area.

I've been runing a :
    grep -r -n "return E" .
on the kernel source as suggested by kernel-janitor homepage to look for 
incorrect return value. Indeed, such return values should look like return -E. 
Here is the result :

./xfs/xfs_itable.c:213:  return EFAULT;
./xfs/xfs_vfsops.c:453:   return EINVAL;
./xfs/xfs_vfsops.c:1664:    return EINVAL;
./xfs/xfs_vfsops.c:1673:    return EINVAL;
./xfs/xfs_vfsops.c:1687:    return EINVAL;
./xfs/xfs_vfsops.c:1694:    return EINVAL;
./xfs/xfs_vfsops.c:1701:    return EINVAL;
./xfs/xfs_vfsops.c:1708:    return EINVAL;
./xfs/xfs_vfsops.c:1724:   return EINVAL;
./xfs/xfs_vfsops.c:1734:    return EINVAL;
./xfs/xfs_vfsops.c:1741:    return EINVAL;
./xfs/xfs_vfsops.c:1749:   return EINVAL;
./xfs/xfs_vfsops.c:1766:   return EINVAL;
./xfs/xfs_vfsops.c:1773:   return EINVAL;
./xfs/xfs_vfsops.c:1780:  return EINVAL;
./xfs/xfs_vfsops.c:1785:  return EINVAL;
./xfs/xfs_vfsops.c:1792:  return EINVAL;
./xfs/xfs_acl.c:108:  return EINVAL;
./xfs/xfs_acl.c:111:  return EINVAL;
./xfs/xfs_acl.c:114:  return EOPNOTSUPP;
./xfs/xfs_acl.c:119:  return EINVAL;
./xfs/xfs_acl.c:134:   return EINVAL;
./xfs/xfs_acl.c:148:   return EINVAL;
./xfs/xfs_acl.c:152:  return EINVAL;
./xfs/xfs_acl.c:391:  return EPERM;
./xfs/xfs_acl.c:393:  return ENOTDIR;
./xfs/xfs_acl.c:395:  return EROFS;
./xfs/xfs_acl.c:401:  return EPERM;
./xfs/xfs_acl.c:456:  return EACCES;
./xfs/xfs_acl.c:458:  return EACCES;
./xfs/xfs_acl.c:462:  return EACCES;
./xfs/xfs_acl.c:630: return EINVAL;
./xfs/xfs_acl.c:777:  return ENOMEM;
./xfs/xfs_cap.c:63:  return EINVAL;
./xfs/xfs_cap.c:66:  return EINVAL;
./xfs/xfs_cap.c:68:  return EINVAL;
./xfs/xfs_cap.c:71:  return EINVAL;
./xfs/xfs_cap.c:194:  return EROFS;
./xfs/xfs_cap.c:196:  return EPERM;
./xfs/xfs_cap.c:204:  return EPERM;
./xfs/xfs_log_recover.c:378:   return ENOMEM;
./xfs/xfs_log_recover.c:440:   return ENOMEM;
./xfs/xfs_log_recover.c:566:  return ENOMEM;
./xfs/xfs_log_recover.c:824:  return ENOMEM;
./xfs/xfs_log_recover.c:1014:  return ENOMEM;
./xfs/xfs_log_recover.c:1141:   return ENOMEM;
./xfs/xfs_log_recover.c:3553:   return ENOMEM;
./xfs/xfs_log_recover.c:3581:  return ENOMEM;
./xfs/xfs_log_recover.c:3585:  return ENOMEM;
./xfs/xfs_mac.c:62:  return EACCES;
./xfs/xfs_attr.c:220:  return EFAULT;  /* match IRIX behaviour */
./xfs/xfs_attr.c:477:  return EFAULT; /* match irix behaviour */
./xfs/xfs_behavior.c:75:   return EINVAL;
./xfs/xfs_vnodeops.c:3702:  * return EAGAIN to indicate to the caller that they
./xfs/xfs_vnodeops.c:3711:   return EAGAIN;
./xfs/xfs_vnodeops.c:3719:    return EAGAIN;
./xfs/xfs_vnodeops.c:3722:   return EAGAIN;

Hope this will help you and linux kernel.

Christophe Jaillet



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.