xfs
[Top] [All Lists]

[Bug 272] xfs_force_shutdown in xfs_trans_cancel, part 2

To: xfs-master@xxxxxxxxxxx
Subject: [Bug 272] xfs_force_shutdown in xfs_trans_cancel, part 2
From: bugzilla-daemon@xxxxxxxxxxx
Date: Tue, 3 Aug 2004 11:12:47 -0700
Sender: linux-xfs-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=272





------- Additional Comments From sandeen@xxxxxxx  2004-03-08 11:12 PDT -------
FWIW, I tried this with a small raid0 of 4 devices, and did not hit the problem.

[root@penguin3 root]# xfs_info /mnt/foo
meta-data=/mnt/foo               isize=256    agcount=16, agsize=555696 blks
         =                       sectsz=512
data     =                       bsize=4096   blocks=8891136, imaxpct=25
         =                       sunit=16     swidth=64 blks, unwritten=1
naming   =version 2              bsize=4096
log      =internal               bsize=4096   blocks=4352, version=1
         =                       sectsz=512   sunit=0 blks
realtime =none                   extsz=262144 blocks=0, rtextents=0

[root@penguin3 root]# mdadm -Q --detail /dev/md0
/dev/md0:
        Version : 00.90.00
  Creation Time : Sat Jul 24 21:16:12 2004
     Raid Level : raid0
     Array Size : 35565056 (33.92 GiB 36.46 GB)
   Raid Devices : 4
  Total Devices : 4
Preferred Minor : 0
    Persistence : Superblock is persistent
 
    Update Time : Sat Jul 24 21:16:12 2004
          State : dirty, no-errors
 Active Devices : 4
Working Devices : 4
 Failed Devices : 0
  Spare Devices : 0
 
     Chunk Size : 64K
 
    Number   Major   Minor   RaidDevice State
       0       8       81        0      active sync   /dev/sdf1
       1       8       97        1      active sync   /dev/sdg1
       2       8      113        2      active sync   /dev/sdh1
       3       8      129        3      active sync   /dev/sdi1
           UUID : 2e3f1b40:01d6b0a0:f08ed8ec:9936997f



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


rom owner-linux-xfs Tue Aug  3 13:11:56 2004
Received: with ECARTIS (v1.0.0; list linux-xfs); Tue, 03 Aug 2004 13:12:06 
-0700 (PDT)
Received: from hermes.fachschaften.tu-muenchen.de 
(hermes.fachschaften.tu-muenchen.de [129.187.202.12])
        by oss.sgi.com (8.13.0/8.13.0) with SMTP id i73KBsjR017872
        for <linux-xfs@xxxxxxxxxxx>; Tue, 3 Aug 2004 13:11:55 -0700
Received: (qmail 28117 invoked from network); 3 Aug 2004 20:04:34 -0000
Received: from mimas.fachschaften.tu-muenchen.de (129.187.202.58)
  by hermes.fachschaften.tu-muenchen.de with QMQP; 3 Aug 2004 20:04:34 -0000
Date: Tue, 3 Aug 2004 22:11:44 +0200
From: Adrian Bunk <bunk@xxxxxxxxx>
To: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxx>,
        Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>,
        xfs-masters@xxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
Subject: Re: [2.6 patch] let 4KSTACKS depend on EXPERIMENTAL (fwd)
Message-ID: <20040803201143.GE2746@xxxxxxxxx>
References: <20040802225951.GR2746@xxxxxxxxx> 
<20040802162846.3929e463.akpm@xxxxxxxx> <20040803004509.GW2746@xxxxxxxxx> 
<1091490958.1647.25.camel@xxxxxxxxxxxxxxxxxxxxx>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1091490958.1647.25.camel@xxxxxxxxxxxxxxxxxxxxx>
User-Agent: Mutt/1.5.6i
X-archive-position: 3824
X-ecartis-version: Ecartis v1.0.0
Sender: linux-xfs-bounce@xxxxxxxxxxx
Errors-to: linux-xfs-bounce@xxxxxxxxxxx
X-original-sender: bunk@xxxxxxxxx
Precedence: bulk
X-list: linux-xfs

On Tue, Aug 03, 2004 at 12:56:01AM +0100, Alan Cox wrote:
> On Maw, 2004-08-03 at 01:45, Adrian Bunk wrote:
> > OTOH, at least XFS is known to have problems with 4kb stacks - and you 
> > don't want such problems to occur in production environments.
> 
> So put && !4KSTACKS in the XFS configuration ?


The patch below does exactly this.

The 4KSTACKS option has to be moved for that it's asked before XFS in
"make config".

diffstat output:
 arch/i386/Kconfig |   18 +++++++++---------
 fs/Kconfig        |    1 +
 2 files changed, 10 insertions(+), 9 deletions(-)


Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.8-rc2-full/arch/i386/Kconfig.old  2004-07-20 21:00:32.000000000 
+0200
+++ linux-2.6.8-rc2-full/arch/i386/Kconfig      2004-07-20 21:03:30.000000000 
+0200
@@ -865,6 +865,15 @@
        generate incorrect output with certain kernel constructs when
        -mregparm=3 is used.
 
+config 4KSTACKS
+       bool "Use 4Kb for kernel stacks instead of 8Kb"
+       help
+         If you say Y here the kernel will use a 4Kb stacksize for the
+         kernel stack attached to each process/thread. This facilitates
+         running more threads on a system and also reduces the pressure
+         on the VM subsystem for higher order allocations. This option
+         will also use IRQ stacks to compensate for the reduced stackspace.
+
 endmenu
 
 
@@ -1289,15 +1299,6 @@
          If you don't debug the kernel, you can say N, but we may not be able
          to solve problems without frame pointers.
 
-config 4KSTACKS
-       bool "Use 4Kb for kernel stacks instead of 8Kb"
-       help
-         If you say Y here the kernel will use a 4Kb stacksize for the
-         kernel stack attached to each process/thread. This facilitates
-         running more threads on a system and also reduces the pressure
-         on the VM subsystem for higher order allocations. This option
-         will also use IRQ stacks to compensate for the reduced stackspace.
-
 config X86_FIND_SMP_CONFIG
        bool
        depends on X86_LOCAL_APIC || X86_VOYAGER
--- linux-2.6.8-rc2-full/fs/Kconfig.old 2004-07-20 21:04:02.000000000 +0200
+++ linux-2.6.8-rc2-full/fs/Kconfig     2004-07-20 21:04:25.000000000 +0200
@@ -294,6 +294,7 @@
 
 config XFS_FS
        tristate "XFS filesystem support"
+       depends on (4KSTACKS=n || BROKEN)
        help
          XFS is a high performance journaling filesystem which originated
          on the SGI IRIX platform.  It is completely multi-threaded, can


<Prev in Thread] Current Thread [Next in Thread>