Re: [PATCH] XFS #if abuses

[Nathan Scott <nathans@xxxxxxx>]

On Sun, Aug 29, 2004 at 06:52:49AM +0100, viro@xxxxxxxxxxxxxxxx wrote:
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxxxxxxxx>

This seems like unnecessary code churn to me.

These macros are used in this way so that some XFS kernel 
headers are the same as the userspace equivalents, so that
we don't end up maintaining diverged duplicate headers.

The patch could go further and remove __BYTE_ORDER, not
sure why that wasn't done.  But, whatever, I'd prefer it
isn't applied unless there's a compelling reason here
that I've overlooked (eg, it actually fixes something?).

thanks.

-- 
Nathan