Re: xfs oops (CVS-2004-05-15_05:00_UTC)

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Jun 23, 2004 at 03:16:11PM +0200, Krzysztof Rusocki wrote:
> It seems that changes included in 1.1371.750.18 may be responsible
> for discussed behavior. Machine's been running without problems
> for over 5 hours now. I'll stress it more and let know whether
> this state is persistent.

Can you try running with the patch below?  This seems to be the only
thing in the cset that could scribble over random memory.  OTOH your
first posting says the linvfs_icache has been sribbled over and pagebuf
doesn't get anywhere the inodes.


--- 1.116/fs/xfs/linux-2.6/xfs_buf.c    2004-05-28 03:45:07 +02:00
+++ edited/fs/xfs/linux-2.6/xfs_buf.c   2004-06-24 12:51:25 +02:00
@@ -312,6 +312,12 @@
 
        ASSERT(list_empty(&bp->pb_hash_list));
 
+       if (!bp->pb_pages) {
+               printk("pagebuf without pb_pages?\n");
+               dump_stack();
+               goto out;
+       }
+
        if (bp->pb_flags & _PBF_PAGE_CACHE) {
                uint            i;
 
@@ -331,6 +337,7 @@
                _pagebuf_free_pages(bp);
        }
 
+ out:
        pagebuf_deallocate(bp);
 }