xfs
[Top] [All Lists]

Re: xfsdump hangs - 2.6.6 && 2.6.7-rc1-bk3

To: dag@xxxxxxxxx
Subject: Re: xfsdump hangs - 2.6.6 && 2.6.7-rc1-bk3
From: Nathan Scott <nathans@xxxxxxx>
Date: Thu, 27 May 2004 15:58:29 +1000
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <20040526091315.17983.h012.c000.wm@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20040526091315.17983.h012.c000.wm@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.3i
On Wed, May 26, 2004 at 09:13:14AM -0700, dag@xxxxxxxxx wrote:
> 
> I experience hangs with xfsdump, when dumping my rootfs to a USB 2.0
> ...
> http://thaifood.homeip.net/xfsdumphang/xfsdump.dmesg.txt 
> ...

The xfsdump stack trace in there is the important one.
Can you try this patch and let me know how it goes?

thanks.

-- 
Nathan


--- fs/xfs/linux/xfs_buf.c.orig 2004-05-27 14:06:59.992936144 +1000
+++ fs/xfs/linux/xfs_buf.c      2004-05-27 14:08:21.548537808 +1000
@@ -370,8 +370,12 @@
              retry:
                page = find_or_create_page(mapping, first + i, gfp_mask);
                if (unlikely(page == NULL)) {
-                       if (flags & PBF_READ_AHEAD)
+                       if (flags & PBF_READ_AHEAD) {
+                               for (--i; i >= 0; i--)
+                                       page_cache_release(bp->pb_pages[i]);
+                               _pagebuf_free_pages(bp);
                                return -ENOMEM;
+                       }
 
                        /*
                         * This could deadlock.


<Prev in Thread] Current Thread [Next in Thread>