xfs
[Top] [All Lists]

Re: Build XFS as module is broken

To: Klaus Strebel <klaus.strebel@xxxxxxxxx>, Bart Samwel <bart@xxxxxxxxx>
Subject: Re: Build XFS as module is broken
From: Nathan Scott <nathans@xxxxxxx>
Date: Fri, 14 May 2004 11:05:15 +1000
Cc: akpm@xxxxxxxx, XFS mailing list <linux-xfs@xxxxxxxxxxx>
In-reply-to: <1084464214.31385.13.camel@xxxxxxxxx>; from bart@xxxxxxxxx on Thu, May 13, 2004 at 06:03:34PM +0200
References: <40A38FB6.9030005@xxxxxxxxx> <1084464214.31385.13.camel@xxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Thu, May 13, 2004 at 06:03:34PM +0200, Bart Samwel wrote:
> On Thu, 2004-05-13 at 17:09, Klaus Strebel wrote:
> > Hi all,
> > 
> > tried to build from the current linux-2.6 cvs tree. Fails with 
> > unresolved symbol 'laptop_mode' :-(. Works with static nonmod build.
> > 
> > EXPORT_SYMBOL(laptop_mode) in mm/page-writeback.c does the trick.
> 
> Thanks for the report. Apparently a patch was forgotten, because I do
> remember submitting one that did this. I submitted a patch to Andrew
> Morton to add this export.
> 

Ah, yes - this one has fallen through the cracks, sorry.
I thought Andrew had applied this in 2.6.6 but didn't cross
check that before merging Barts final laptop mode patch into
our tree.  Fixed in the XFS tree now, Andrew could you apply
this patch to mainline?

thanks.

-- 
Nathan


Index: 2.6.x-xfs/mm/page-writeback.c
===================================================================
--- 2.6.x-xfs.orig/mm/page-writeback.c  Tue May 11 14:54:17 2004
+++ 2.6.x-xfs/mm/page-writeback.c       Fri May 14 10:52:56 2004
@@ -91,6 +91,7 @@
  * Flag that puts the machine in "laptop mode".
  */
 int laptop_mode;
+EXPORT_SYMBOL(laptop_mode);
 
 /* End of sysctl-exported parameters */
 


<Prev in Thread] Current Thread [Next in Thread>