xfs
[Top] [All Lists]

Re: typo in XFS_IOC_GETXFLAGS?

To: Herbert Poetzl <herbert@xxxxxxxxxxxx>
Subject: Re: typo in XFS_IOC_GETXFLAGS?
From: Nathan Scott <nathans@xxxxxxx>
Date: Tue, 4 May 2004 08:55:46 +1000
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20040503215840.GA26617@xxxxxxxxxxxxxxxxx>; from herbert@xxxxxxxxxxxx on Mon, May 03, 2004 at 11:58:41PM +0200
References: <20040503215840.GA26617@xxxxxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
Hi Herbert,

On Mon, May 03, 2004 at 11:58:41PM +0200, Herbert Poetzl wrote:
> 
> Hi Folks!
> 
> xfs_ioc_xattr() uses in XFS_IOC_GETXFLAGS the
> XFS_XFLAG_* defines for di_flags comparison, 
> shouldn't that be XFS_DIFLAG_IMMUTABLE and 
> friends instead?
> 
>                 if (ip->i_d.di_flags & XFS_XFLAG_IMMUTABLE)
>                         flags |= LINUX_XFLAG_IMMUTABLE;
>                 if (ip->i_d.di_flags & XFS_XFLAG_APPEND)
>                         flags |= LINUX_XFLAG_APPEND;

Yep, good catch - thanks.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>