Nathan Scott wrote:
On Tue, May 11, 2004 at 03:40:57PM -0700, Andrew Morton wrote:
bart@xxxxxxxxx wrote:
The laptop mode control script incorrectly guesses XFS_HZ=1000.
I thought you switched the laptop mode XFS patches to USER_HZ to
avoid this issue Bart?
I did. But I forgot to update the Laptop Mode control script to use the
common USER_HZ value as well, and that's what this patch is for. (In
fact, I didn't see that the USER_HZ patch went in until 2.6.6 came out,
so that's why I didn't submit this patch earlier.)
aargh. XFS is broken. It shouldn't be exposing jiffy-based tunables into
/proc, or `mount -o remount' or whatever.
It would be much better to rework XFS so that these user-visible tunables
are in units of milliseconds, centiseconds or whatever.
They're in USER_HZ since 2.6.6. Andrew, is that OK or should they really
be in some even more fixed unit?
--Bart
|