xfs
[Top] [All Lists]

Re: typo in XFS_IOC_GETXFLAGS?

To: Herbert Poetzl <herbert@xxxxxxxxxxxx>
Subject: Re: typo in XFS_IOC_GETXFLAGS?
From: Nathan Scott <nathans@xxxxxxx>
Date: Tue, 4 May 2004 12:32:34 +1000
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20040503230042.GA27312@MAIL.13thfloor.at>; from herbert@13thfloor.at on Tue, May 04, 2004 at 01:00:42AM +0200
References: <20040503215840.GA26617@MAIL.13thfloor.at> <20040504085546.B127559@wobbly.melbourne.sgi.com> <20040503230042.GA27312@MAIL.13thfloor.at>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
Hi Herbert,

On Tue, May 04, 2004 at 01:00:42AM +0200, Herbert Poetzl wrote:
> On Tue, May 04, 2004 at 08:55:46AM +1000, Nathan Scott wrote:
> > On Mon, May 03, 2004 at 11:58:41PM +0200, Herbert Poetzl wrote:
> > > 
> > > xfs_ioc_xattr() uses in XFS_IOC_GETXFLAGS the
> > > XFS_XFLAG_* defines for di_flags comparison, 
> > > shouldn't that be XFS_DIFLAG_IMMUTABLE and 
> > > friends instead?
> > > 
> > Yep, good catch - thanks.
> 
> well, stumbled over another one ... this
> actually needs a little additional code ...

Actually, it turns out that both of these are fine (thought
I tested this!) because the XFS_XFLAG and XFS_DIFLAG values
are the same.  Still, its pretty confusing - I'll clear it
up in the code.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>