[Top] [All Lists]

Re: [PATCH] lockfs patch for 2.6

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] lockfs patch for 2.6
From: Andrew Morton <akpm@xxxxxxxx>
Date: Sun, 14 Mar 2004 10:44:39 -0800
Cc: mason@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <20040314140032.A8901@xxxxxxxxxxxxx>
References: <1078867885.25075.1458.camel@xxxxxxxxxxxxx> <20040313131447.A25900@xxxxxxxxxxxxx> <1079191213.4187.243.camel@xxxxxxxxxxxxx> <20040313163346.A27004@xxxxxxxxxxxxx> <20040314140032.A8901@xxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> + * This takes the block device bd_mount_sem to make sure no new mounts
>  + * happen on bdev until unlockfs is called.  If a super is found on this
>  + * block device, we hould a read lock on the s->s_umount sem to make sure
>  + * nobody unmounts until the snapshot creation is done
>  + */
>  +struct super_block *freeze_bdev(struct block_device *bdev)

I think you do need s_umount, as the comments say.  But this patch doesn't
touch it.

<Prev in Thread] Current Thread [Next in Thread>