Re: [PATCH] lockfs patch for 2.6

[Andrew Morton <akpm@xxxxxxxx>]

Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> + * This takes the block device bd_mount_sem to make sure no new mounts
>  + * happen on bdev until unlockfs is called.  If a super is found on this
>  + * block device, we hould a read lock on the s->s_umount sem to make sure
>  + * nobody unmounts until the snapshot creation is done
>  + */
>  +struct super_block *freeze_bdev(struct block_device *bdev)

I think you do need s_umount, as the comments say.  But this patch doesn't
touch it.