Ram Pai wrote:
On Wed, 2004-02-18 at 07:19, Dean Roehrich wrote:
It probably needs to be upgraded to the latest autotools. It's a bit old.
I don't have an rpm for the binaries.
Ok. I am not able to run this test suite. In any case, I want to
validate the behavior of XFS for pre-unmount event.
As per the spec the pre-unmount event should be generated before the
operation is about to check for open files. However given the current
VFS code I am not sure, how could ever any filesystem support this
feature correctly.
You are probably correct here, the vfs keeps track of the busy count
and apart from the unmount_begin operation which is called in the
MNT_FORCE case, there is not a lot of opportunity to insert this
call. If the pre-unmount event is allowed to fail the unmount
then this will not work either since it does not stop the unmount.
The VFS code may not even inform the filesystem specific unmount handler
in some cases. As a result no filesystem can ever support this feature
correctly. Is my understanding correct? Does XFS provide the
pre-unmount event correctly?
There is a pre_unmount event in xfs, it is after the vfs has cleaned
up all the inodes (in the put_super code), if it returns an error
then the vfs will still finish the unmount, and you may well get one
of those self destruct in 5 seconds messages.
Any ideas?
RP
Al Viro is distinctly anti dmapi, so chances are slim to none I would
say.
Steve
|