xfs
[Top] [All Lists]

Re: [Swsusp-devel] Re: Swapfiles broken on XFS.

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [Swsusp-devel] Re: Swapfiles broken on XFS.
From: Nigel Cunningham <ncunningham@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 10 Jan 2004 07:06:26 +1300
Cc: XFS list <linux-xfs@xxxxxxxxxxx>, Karol Kozimor <sziwan@xxxxxxxxxxx>, swsusp-devel <swsusp-devel@xxxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20040109161653.A25678@infradead.org>
References: <1073620506.3790.21.camel@laptop-linux> <20040109161653.A25678@infradead.org>
Reply-to: ncunningham@xxxxxxxxxxxxxxxxxxxxx
Sender: linux-xfs-bounce@xxxxxxxxxxx
Hi.

Do you know what other filesystems do (haven't had a chance to look for
myself yet)? I guess they're using s_blocksize ==
bdev->bd_block_size/i_blkbits, since we haven't seen this issue before.
If that's the case, the solution would be to switch what we look at,
yes?

Regards,

Nigel

On Sat, 2004-01-10 at 05:16, Christoph Hellwig wrote:
> On Fri, Jan 09, 2004 at 04:55:09PM +1300, Nigel Cunningham wrote:
> > It appears to me that a swapfile on an XFS filesystem will not work, at
> > least some of the time.
> 
> XFS sets s_blocksize to the filesystem blocksize and bdev->bd_block_size /
> i_blkbits to the XFS sector size.  The first would be 4096 in your
> case and the latter 512.  We cannot set a bigger device block size because
> XFS log writes are in 512b units.
> 
> I don't think the swap code should do any assumptions about any relation
> of the above two.
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Perforce Software.
> Perforce is the Fast Software Configuration Management System offering
> advanced branching capabilities and atomic changes on 50+ platforms.
> Free Eval! http://www.perforce.com/perforce/loadprog.html
> _______________________________________________
> swsusp-devel mailing list
> swsusp-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/swsusp-devel
-- 
My work on Software Suspend is graciously brought to you by
LinuxFund.org.

Attachment: signature.asc
Description: This is a digitally signed message part

<Prev in Thread] Current Thread [Next in Thread>