On Friday 07 Nov 2003 5:31 pm, Stefan Smietanowski wrote:
> Hi Ajay.
> > Eric,
> I'm not Eric, nor do I claim to be Eric but I want to respond anyway :)
> > Success on the anaconda front, I have a installer that has proper rescue
> > support. Here are the patches that I have added to the installer. I am no
> > closer to finding an answer to the grub problem, but I am working on it.
> Rescue support ? You mean that "mount filesystems" works? Or did you
> mean "upgrade" support?
The rescue cd works for mount filesystems, yes
> But before I continue : WELL DONE! Saves me a load of time.
Thanks, as ESR says if you have an itch scratch it, much of all this was done
by others before all I did was build on those bits.
> > +def readFSLabel(device, makeDevNode = 1):
> > + label = readXFSLabel(device, makeDevNode)
> > + if (label == None):
> > + label = readExt2Label(device, makeDevNode)
> > + return label
> > +
> > +#def readFSLabel(device, makeDevNode = 1):
> > +# fstype = partedUtils.sniffFilesystemType(device)
> > +# if (fstype == "ext2" or fstype == "ext3")
> > +# return readExt2Label(device, makeDevNode)
> > +# elif (fstype == "xfs"):
> > +# return readXFSLabel(device, makeDevNode)
> > +# else:
> > +# return ""
> > +
> Umm... why? Before they check what filesystem it is and then
> use the correct way to read the label and you instead just assume
> it's XFS and if the label reading fails then you try if it's ext2.
> I'm probably missing something though.
just enable the so called correct way of doing it and import partedUtils in
isys/isys.py and watch anaconda fall apart. It has something to do with
circular imports and I dont have the time, knolwedge and paitence to sort it
> > - $BUILDINSTALL --buildinstdir $BUILDINSTDIR --second $PKGORDERSTR
> > --comp $COMPNAME --version $VERSION --release \"$RELEASESTR\" --product
> > \"$PRODUCTSTR\" --prodpath $PRODUCTPATH $DIR + $BUILDINSTALL
> > --buildinstdir $BUILDINSTDIR --second $PKGORDERSTR --comp $COMPNAME
> > --version $VERSION --release "$RELEASESTR" --product "$PRODUCTSTR"
> > --prodpath $PRODUCTPATH $DIR
> Why do you remove the "\" ? If $RELEASESTR is something with a space
> this will not work.
I am using this to invoke the buildinstall
/usr/lib/anaconda-runtime/buildinstall --comp dist-1 --pkgorder
/tmp/pkgorder.lst --version 1 --product 'Fedora Core XFS' --release 1
--prodpath Fedora $BASEDIR/i386
if I use the \" it will not work I have tried various ways of quoting that
string "Fedora\ Core\ XFS", with single quotes, double quotes, with backslash
escapes for the spaces and all combos thereof to no avail.
> Also, I see you adding JFS support here and there but not everywhere.
> Not necessary in other places or ... ?
I am just adding in the easy bits, like getting the filesystem recognized
etc., since I see FIXME in the code. I dont use JFS anywhere on my system so
I am not enabling much more deep stuff like label support for JFS etc.
After booting the rescue CD, I was tempted to "eat my own dogfood" and tried
to do a HDD install from the rescue CD, but since I had the ISO images on a
XFS partition that failed, I have since added this patch to my copy of
You will want to add this on too.
Thanks & regards
Description: Text Data