On Fri, Oct 24, 2003 at 10:59:19AM +1000, Ivan Rayner wrote:
> On Sun, 19 Oct 2003 23:31:51 -0800, Ethan Benson wrote:
>
> > Recently my patches to add file flags to XFS were merged (immutable,
> > append-only etc). xfsdump has some problems with the new flags:
> ...
> > What I have done to fix the above problems in order:
>
> Thanks for your work Ethan. Although I've not looked your code, it sounds
> like you're doing the right sort of thing.
hopefully, let me know when you get a chance to look at the code.
> > * dump/inomap.c: Add warning when SGI_XFSDUMP_SKIP_FILE xattr is
> > present, but still honor it, this attribute is deprecated in favor of
> > the new nodump file flag, support for the obsolete xattr should be
> > removed in a future xfsdump (its not that old so this shouldn't be
> > much of a problem). Add check for new nodump file flag.
>
> The SKIP_FILE attribute is still the supported mechanism in IRIX,
> therefore it'd be a good idea to keep support for it in the Linux version.
> It doesn't hurt performance, so I don't see any reason to remove it.
well its very young, it was just added last year i think, maybe more
recently then that (by request from linux users wanting chattr +d
functionality). and the file attributes will probably end up getting
merged into irix anyway. the inode flags are really a much cleaner
way for this to work, which is why id rather see the xattr kludge go
away.
--
Ethan Benson
http://www.alaska.net/~erbenson/
pgp5LxcRAy0Qz.pgp
Description: PGP signature
|