xfs
[Top] [All Lists]

Re: BLKGETSIZE64, BLKBSZSET, BLKSSZGET definition in xfsprogs.

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: BLKGETSIZE64, BLKBSZSET, BLKSSZGET definition in xfsprogs.
From: Jan Derfinak <ja@xxxxxxxxxxxx>
Date: Tue, 7 Oct 2003 11:21:06 +0200 (CEST)
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20031006055957.GC1001@frodo>
References: <Pine.LNX.4.53.0310060739360.16790@xxxxxxxxxxxxxxxxxx> <20031006055957.GC1001@frodo>
Sender: linux-xfs-bounce@xxxxxxxxxxx
On Mon, 6 Oct 2003, Nathan Scott wrote:

> On Mon, Oct 06, 2003 at 07:48:11AM +0200, Jan Derfinak wrote:
> > Hi.
> >
> > While looking to xfsprogs source I found that xfsprogs defines BLKGETSIZE64,
> > BLKBSZSET and BLKSSZGET in libxfs/linux.c. These macros are also defined in
> > /usr/include/linux/fs.h. I'm curious why xfsprogs doesn't include
>               ^^^^^^^
...
> Actually, IIRC these are all conditionally compiled (so if they are
> already defined via system headers, we use the already-set values).
> Not that it matters, they should never have any value different to
> what we define them to here.

There was change in 2.6.0-test5 and linux/fs.h isn't included in
xfsprogs so xfsprogs uses old definition.

> bzcat patch-2.6.0-test5.bz2 | grep -e BLKBSZSET -e BLKGETSIZE64
-#define BLKBSZSET  _IOW(0x12,113,sizeof(int))
-#define BLKGETSIZE64 _IOR(0x12,114,sizeof(u64))        /* return device size 
in bytes (u64 *arg) */
+#define BLKBSZSET  _IOW(0x12,113,size_t)
+#define BLKGETSIZE64 _IOR(0x12,114,size_t)     /* return device size in bytes 
(u64 *arg) */


                                jan

-- 


<Prev in Thread] Current Thread [Next in Thread>