xfs
[Top] [All Lists]

[hch: [PATCH] kill a bogus assert]

To: linux-xfs@xxxxxxxxxxx
Subject: [hch: [PATCH] kill a bogus assert]
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 3 Sep 2003 12:46:13 +0200
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
Okay, Steve is away..

----- Forwarded message from Christoph Hellwig <hch> -----

Date: Wed, 3 Sep 2003 12:32:19 +0200
From: Christoph Hellwig <hch>
Subject: [PATCH] kill a bogus assert
To: lord@xxxxxxx

gcc 3.3 complains about this and indeed it can only trigger if
someone magically enlarges __uint8_t :)


--- 1.11/fs/xfs/xfs_dir_leaf.c  Thu Aug  7 16:58:33 2003
+++ edited/fs/xfs/xfs_dir_leaf.c        Wed Sep  3 11:23:02 2003
@@ -1835,7 +1835,6 @@
        entry_d = &leaf_d->entries[start_d];
        for (i = 0; i < count; entry_s++, entry_d++, i++) {
                ASSERT(INT_GET(entry_s->nameidx, ARCH_CONVERT) >= 
INT_GET(hdr_s->firstused, ARCH_CONVERT));
-               ASSERT(entry_s->namelen < MAXNAMELEN);
                tmp = XFS_DIR_LEAF_ENTSIZE_BYENTRY(entry_s);
                INT_MOD(hdr_d->firstused, ARCH_CONVERT, -(tmp));
                entry_d->hashval = entry_s->hashval; /* INT_: direct copy */

----- End forwarded message -----


<Prev in Thread] Current Thread [Next in Thread>
  • [hch: [PATCH] kill a bogus assert], Christoph Hellwig <=