xfs
[Top] [All Lists]

Re: Redhat beta kernel compile fix

To: Utz Lehmann <u.lehmann@xxxxxxxxxxxxxx>
Subject: Re: Redhat beta kernel compile fix
From: Axel Thimm <Axel.Thimm@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 14 Sep 2003 12:04:32 +0300
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20030911172635.GB13348@de.tecosim.com>
References: <20030911172635.GB13348@de.tecosim.com>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Hi,

On Thu, Sep 11, 2003 at 07:26:35PM +0200, Utz Lehmann wrote:
> I made a patch which make it compile and working under redhat 9 for me.
> I got the idea for the patch from
> http://oss.software.ibm.com/pipermail/jfs-discussion/2003-May/001407.html
> 
> I dont know if it is the right fix. But it survived 1h of fsx and a few FEM
> analysis jobs on an UP athlon.
> 
> Maybe it is useful for someone.

Thanks, the patch needs two fixes

a) "recalc_sigpending;" should become "recalc_sigpending();",
   otherwise it is simply never called.
b) The code from fs/xfs/linux/xfs_syncd.c is now in fs/xfs/linux/xfs_super.c

> diff -ru linux-2.4.21-20.1.2024.2.1.nptl/fs/xfs/linux/xfs_syncd.c 
> linux-2.4.21-20.1.2024.2.1.nptl_teco1/fs/xfs/linux/xfs_syncd.c
> +++ linux-2.4.21-20.1.2024.2.1.nptl_teco1/fs/xfs/linux/xfs_syncd.c    
> 2003-09-09 11:32:08.000000000 +0200
> @@ -49,10 +49,10 @@
>  
>       daemonize();
>       reparent_to_init();
> -     spin_lock_irq(&current->sigmask_lock);
> +     spin_lock_irq(&current->sighand->siglock);
>       sigfillset(&current->blocked);
> -     recalc_sigpending(current);
> -     spin_unlock_irq(&current->sigmask_lock);
> +     recalc_sigpending;
> +     spin_unlock_irq(&current->sighand->siglock);
>  
>       sprintf(current->comm, "xfs_syncd");
>  
> diff -ru linux-2.4.21-20.1.2024.2.1.nptl/fs/xfs/pagebuf/page_buf.c 
> linux-2.4.21-20.1.2024.2.1.nptl_teco1/fs/xfs/pagebuf/page_buf.c
> +++ linux-2.4.21-20.1.2024.2.1.nptl_teco1/fs/xfs/pagebuf/page_buf.c   
> 2003-09-09 11:33:26.000000000 +0200
> @@ -1920,10 +1920,10 @@
>       daemonize();
>  
>       /* Avoid signals */
> -     spin_lock_irq(&current->sigmask_lock);
> +     spin_lock_irq(&current->sighand->siglock);
>       sigfillset(&current->blocked);
> -     recalc_sigpending(current);
> -     spin_unlock_irq(&current->sigmask_lock);
> +     recalc_sigpending;
> +     spin_unlock_irq(&current->sighand->siglock);
>  
>       /* Migrate to the right CPU */
>       migrate_to_cpu(cpu);
> @@ -2021,10 +2021,10 @@
>       daemonize();
>  
>       /* Avoid signals */
> -     spin_lock_irq(&current->sigmask_lock);
> +     spin_lock_irq(&current->sighand->siglock);
>       sigfillset(&current->blocked);
> -     recalc_sigpending(current);
> -     spin_unlock_irq(&current->sigmask_lock);
> +     recalc_sigpending;
> +     spin_unlock_irq(&current->sighand->siglock);
>  
>       strcpy(current->comm, "pagebufd");
>       current->flags |= PF_MEMALLOC;


-- 
Axel.Thimm@xxxxxxxxxxxxxxxxxxx

Attachment: pgpPgWFbC3qgX.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>