[Top] [All Lists]

Re: Patch 1300 & rpm issue with 1.3.0

To: Axel Thimm <Axel.Thimm@xxxxxxxxxxxxxxxxxxx>
Subject: Re: Patch 1300 & rpm issue with 1.3.0
From: Eric Sandeen <sandeen@xxxxxxx>
Date: 26 Aug 2003 16:18:34 -0500
Cc: Simon Matter <simon.matter@xxxxxxxxxxxxxxxx>, Kai Leibrandt <k_leibrandt@xxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <20030826161953.GB6163@xxxxxxxxxxx>
References: <20030826142327.GB3818@xxxxxxxxxxx> <Pine.LNX.4.44.0308260955410.8882-100000@xxxxxxxxxxxxxxxxxxxxxx> <20030826153708.GG3818@xxxxxxxxxxx> <1061913418.13459.13.camel@xxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.44.0308241122220.16149-100000@xxxxxxxxxxxxxxxxxxxxxx> <3F4B73F3.1A08113B@xxxxxxxxxxxxxxxx> <1061912643.13459.1.camel@xxxxxxxxxxxxxxxxxxxxxx> <20030826161953.GB6163@xxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
Argh, here's one thing that went wrong... my cscope database did not
index fs/ext3/file.c, for some reason... so I did not modify it, and
O_DIRECT was not getting turned off for ext3 - hence the problem on ext3

I'll test it again on xfs roots... it is probably still a problem there.

But at least we can make it behave on "stock" ext3 roots, now.  And the
failure is a -little- less mysterious.

Adding this to the bottom of "linux-2.4.20-xfs-directio-ok.patch" will
get ext3 going again

--- linux-2.4.20-19.9.XFS1.3.0/fs/ext3/file.c   2002-11-28 17:53:15.000000000 
+++ linux/fs/ext3/file.c        2003-08-26 15:23:43.000000000 -0500
@@ -46,6 +46,7 @@
 static int ext3_open_file (struct inode * inode, struct file * filp)
+       filp->f_flags &= ~O_DIRECT;
        if (!(filp->f_flags & O_LARGEFILE) &&
            inode->i_size > 0x7FFFFFFFLL)
                return -EFBIG;

Eric Sandeen      [C]XFS for Linux   http://oss.sgi.com/projects/xfs
sandeen@xxxxxxx   SGI, Inc.          651-683-3102

<Prev in Thread] Current Thread [Next in Thread>