Re: Patch 1300 & rpm issue with 1.3.0

[Eric Sandeen <sandeen@xxxxxxx>]

Argh, here's one thing that went wrong... my cscope database did not
index fs/ext3/file.c, for some reason... so I did not modify it, and
O_DIRECT was not getting turned off for ext3 - hence the problem on ext3
roots.

I'll test it again on xfs roots... it is probably still a problem there.

But at least we can make it behave on "stock" ext3 roots, now.  And the
failure is a -little- less mysterious.

Adding this to the bottom of "linux-2.4.20-xfs-directio-ok.patch" will
get ext3 going again

--- linux-2.4.20-19.9.XFS1.3.0/fs/ext3/file.c   2002-11-28 17:53:15.000000000 
-0600
+++ linux/fs/ext3/file.c        2003-08-26 15:23:43.000000000 -0500
@@ -46,6 +46,7 @@
  */
 static int ext3_open_file (struct inode * inode, struct file * filp)
 {
+       filp->f_flags &= ~O_DIRECT;
        if (!(filp->f_flags & O_LARGEFILE) &&
            inode->i_size > 0x7FFFFFFFLL)
                return -EFBIG;


-Eric
-- 
Eric Sandeen      [C]XFS for Linux   http://oss.sgi.com/projects/xfs
sandeen@xxxxxxx   SGI, Inc.          651-683-3102