xfs
[Top] [All Lists]

Re: use-after-free in xfs_bawrite()

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: use-after-free in xfs_bawrite()
From: Andrew Morton <akpm@xxxxxxxx>
Date: Sat, 2 Aug 2003 05:09:19 -0700
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20030802115458.GA21440@xxxxxxxxxxxxx>
References: <20030802013032.7a42a596.akpm@xxxxxxxx> <20030802115458.GA21440@xxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
Andi Kleen <ak@xxxxxxx> wrote:
>
> On Sat, Aug 02, 2003 at 01:30:32AM -0700, Andrew Morton wrote:
> > 
> > XFS has waaaaay too much inlining btw ;)
> 
> Really? 
> 
> The core code (outside linux/, pagebuf/) only has a single inline.
> linux/ has four. 
> pagebuf/ has three.
> quota/ has four. 
> support/* some more similar to the original linux functions.

hm, OK, well the code I looked at tonight had too many anyway. 
xfs_bawrite(), xfs_buf_undelay() and _pagebuf_iodone().  Guess I got lucky.

> > Seems that dbench is not XFS's favourite benchmark.  How come?  Do I need
> > more logbufs?
> 
> And bigger on disk log than by default.  There is a patch in the queue to do 
> the first, but I think it hasn't reached Linus' tree yet.
> 

Your patch has been merged, and is in the tree I tested.


<Prev in Thread] Current Thread [Next in Thread>