Andi Kleen <ak@xxxxxxx> wrote:
> On Sat, Aug 02, 2003 at 01:30:32AM -0700, Andrew Morton wrote:
> > XFS has waaaaay too much inlining btw ;)
> The core code (outside linux/, pagebuf/) only has a single inline.
> linux/ has four.
> pagebuf/ has three.
> quota/ has four.
> support/* some more similar to the original linux functions.
hm, OK, well the code I looked at tonight had too many anyway.
xfs_bawrite(), xfs_buf_undelay() and _pagebuf_iodone(). Guess I got lucky.
> > Seems that dbench is not XFS's favourite benchmark. How come? Do I need
> > more logbufs?
> And bigger on disk log than by default. There is a patch in the queue to do
> the first, but I think it hasn't reached Linus' tree yet.
Your patch has been merged, and is in the tree I tested.