xfs
[Top] [All Lists]

Re: [Bug 213] XFS kernel patch breaks kdemultimedia

To: linux-xfs@xxxxxxxxxxx
Subject: Re: [Bug 213] XFS kernel patch breaks kdemultimedia
From: Ethan Benson <erbenson@xxxxxxxxxx>
Date: Mon, 30 Jun 2003 02:18:21 -0800
In-reply-to: <200306300853.h5U8r8rG002973@xxxxxxxxxxx>
Mail-copies-to: nobody
Mail-followup-to: linux-xfs@xxxxxxxxxxx
References: <200306300853.h5U8r8rG002973@xxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Mon, Jun 30, 2003 at 01:53:08AM -0700, bugzilla-daemon@xxxxxxxxxxx wrote:
> http://oss.sgi.com/bugzilla/show_bug.cgi?id=213
> 
> 
> kelledin@xxxxxxxxxxxxxxxxxxx changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|RESOLVED                    |REOPENED
>          Resolution|INVALID                     |
> 
> 
> 
> 
> ------- Additional Comments From kelledin@xxxxxxxxxxxxxxxxxxx  2003-30-06 
> 01:53 PDT -------
> This is actually NOT a KDE bug.  It's an XFS bug.  The problem is that if gcc 
> -ansi is used, the 

yes it is a KDE bug.  userspace shall NEVER include kernel headers,
doing so is a bug.

> kdemultimedia's CD player app (KsCD IIRC) hits this because it includes 
> <linux/cdrom.h>, which 

which is a bug.

> indirectly includes <asm/byteorder.h>.  KsCD has a pretty obvious need to do 
> this, I think. ;) 

it should have its own local copies of whatever it needs then, it
should NOT be including kernel headers directly.

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgp1pual2NpEP.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>