xfs
[Top] [All Lists]

linux/fs/xfs/xfs_log.h:_lsn_cmp not declared __inline__ with gcc 2.95

To: linux-xfs@xxxxxxxxxxx
Subject: linux/fs/xfs/xfs_log.h:_lsn_cmp not declared __inline__ with gcc 2.95
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Fri, 14 Feb 2003 12:10:59 -0800
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
linux/fs/xfs/xfs_log.h seems to want to declare _lsn_cmp() only for
GCC versions != 2.95.

Why is this?

It means with gcc-2.95 we get lots of copies of this function declared
and never used.

The following patch prevents this and seems to work perfect with
2.95...


===== fs/xfs/xfs_log.h 1.2 vs edited =====
--- 1.2/fs/xfs/xfs_log.h        Mon Feb  3 10:19:33 2003
+++ edited/fs/xfs/xfs_log.h     Fri Feb 14 00:18:21 2003
@@ -52,12 +52,7 @@
  * By comparing each compnent, we don't have to worry about extra
  * endian issues in treating two 32 bit numbers as one 64 bit number
  */
-static
-#ifdef __GNUC__
-# if !((__GNUC__ == 2) && (__GNUC_MINOR__ == 95))
-__inline__
-#endif
-#endif
+static __inline__
 xfs_lsn_t      _lsn_cmp(xfs_lsn_t lsn1, xfs_lsn_t lsn2, xfs_arch_t arch)
 {
        if (CYCLE_LSN(lsn1, arch) != CYCLE_LSN(lsn2, arch))



  --cw


<Prev in Thread] Current Thread [Next in Thread>