Christoph Hellwig wrote:
>
> > Why don't you comment on the other things I posted:
> > (which I consider to be the real issues)
> > - the pg locking clearly pulled in one place,
> > - coalescing pagesync_t into pg with a single atomic var,
> > - the if goto fiasco,
> > - having extra code with one purpose: debugging,
> > (not talking about BUG()) removed.
> > - a centralized generic_make_request() calling scheme,
> > rather than all over the place,
> > - etc...
> > This would make sense and help xfs improve, not nit-picking
> > short conditionals.
>
> What about submitting one patch per change, with a usefull comment
> instead of ranting?
No, you are the one ranting.
I did submit a patch. I did sumbit helpful to XFS improvement hints
and suggestions. On whole I have had only 2 days of looking at the
XFS code and thus I cannot be of any more help. I doubt I'll
touch XFS code anymore, for reasons mentioned below.
In fact all you do is wait for me to post something and then
_you_ start ranting, offending, etc. Check the archives --
see for yourself.
And why would I post a patch, after the attitude I've seen here?
So that you can only attack it? Look, you get involved in arguing
about short conditionals, which in a year or so everyone will be using...
Look, all you do is preach kernel legalism here, rather than
say what makes and what doesn't *make sense*, and this is what matters
since this is how the kernel gets improved -- not by preaching legalism
(like you do, getting cought up on setting bits), but by telling
what *makes sense*.
If everyone was like you -- the kernel would NOT have moved at all.
Your behaviour here is NOT helpful to XFS improvement!
As you can see none of your replies to me were of XFS improvement.
It was only self-gratification, nit-picking and legalism,
rather than, "yes that makes sense", and "no that doesn't make sense,
but the same effect can be accomplished like so" -- you see, positiveness
on the whole. How long have you waited to use the ``crack smoking'' phrase?
You finally did. Bravo!
I guess you want to find a mailing list, where you can reign free
and attack ppl. Why don't you do this on linux-kernel?
If you know so much about the XFS code and in general, why don't
*you* post patches on the things you agree (agree?! -- yeah, right)
are needed for XFS?
You behaviour here is hardly professional and helpful to
XFS.
BUG 182 seems to be resolved.
You've successfully managed to turn away another programmer
from this list. The XFS team can thank you now.
Good luck to the rest of you,
--
Luben
|