Re: PATCH: sleeping while holding a lock in _pagebuf_free_bh()::page_buf.c

[Stephen Lord <lord@xxxxxxx>]

On Mon, 2002-10-21 at 18:56, Luben Tuikov wrote:
> Problem: on an SMP system, BANG#@!, the unthinkable happens.
> Solution: never sleep when holding a lock.
> 
> This patch applies to CVS code as of about 18:30 EDT
> on Mon Oct 21 (today), and is self-explanatory.
> 
> This patch fixes the problem of the mount going into D state
> indefinitely when the RAID is syncing and mount is run
> right after mkfs.xfs (from shell script, no sleep between,
> low system load, SMP).
> 
> If you know of similar incidents in other parts of the code
> those should be fixed, probably ASAP.

Rethinking this, the wake_up does not actually sleep. All
this change does is change it from waking all waiters 
on this lock to waking one of them.

Steve