xfs
[Top] [All Lists]

Re: PATCH: sleeping while holding a lock in _pagebuf_free_bh()::page_bu

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: PATCH: sleeping while holding a lock in _pagebuf_free_bh()::page_buf.c
From: Andrew Morton <akpm@xxxxxxxxx>
Date: Tue, 22 Oct 2002 17:20:14 -0700
Cc: Luben Tuikov <luben@xxxxxxxxxxxx>, linux-xfs <linux-xfs@xxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxx>
References: <3DB49424.9E4CAC0F@splentec.com> <20021022213140.A11191@infradead.org>
Sender: linux-xfs-bounce@xxxxxxxxxxx
Christoph Hellwig wrote:
> 
> -
> -               if (waitqueue_active(&pb_resv_bh_wait)) {
> -                       wake_up(&pb_resv_bh_wait);
> -               }
> -
>                 spin_unlock_irqrestore(&pb_resv_bh_lock, flags);
> +               wake_up(&pb_resv_bh_wait);
>         }
>  }
> 

I'd be interested in a description of how this can help
avoid a deadlock.


<Prev in Thread] Current Thread [Next in Thread>