xfs
[Top] [All Lists]

Re: [2.4.18-14SGI_XFS_1.2a1] acl problems

To: linux-xfs@xxxxxxxxxxx
Subject: Re: [2.4.18-14SGI_XFS_1.2a1] acl problems
From: Ethan Benson <erbenson@xxxxxxxxxx>
Date: Sat, 12 Oct 2002 20:24:17 -0800
In-reply-to: <20021013035929.GA4505@bonzo.nirvana>
Mail-copies-to: nobody
Mail-followup-to: linux-xfs@xxxxxxxxxxx
References: <20021012153026.GA17332@bonzo.nirvana> <20021012204316.GP13549@plato.local.lan> <20021011010713.GA4254@bonzo.nirvana> <20021011014047.GA27651@tapu.f00f.org> <20021011020437.GA1144622@down.physik.fu-berlin.de> <20021011211538.GA27574@sgi.com> <20021011010713.GA4254@bonzo.nirvana> <1034370565.14233.33.camel@stout.americas.sgi.com> <20021012153026.GA17332@bonzo.nirvana> <20021013035929.GA4505@bonzo.nirvana>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Sun, Oct 13, 2002 at 05:59:29AM +0200, Axel Thimm wrote:
> > you will see a system.posix_acl_access attribute (system.* is not
> > displayed by default).
> 
> I also see a xfsroot.SGI_ACL_FILE entry.

yes you will see that if you run getfattr as root.  you don't need to
mess with that one.

> > you can remove them with:
> > setfattr -x system.posix_acl_access file
> 
> Which also removes the xfsroot.SGI_ACL_FILE entry (as it should, I guess).

yes, the xfsroot attribute handled automatically in the kernel.

> > can you try this test by removing the acl with the above setfattr
> > command instead of setfacl (which seems to be partly broken in regards
> > to acl removal) 
> 
> Yes, it works as you describe it. Thanks, it works better for restoring my
> files then copying them back and forth with non-acl aware tools (like local
> rsync).
> 
> So there are three bugs?
> a) XFS code should automatically remove ACL attributes if not needed anymore.

yes

> b) same for setfacl.

maybe, i tend to think not, it really needs to be handled in the
kernel automatically to be truly effective.

> c) files with ACLs appear as executable for root.

yes

> If a) is not done in the kernel but in the userland, then maybe a) & b) are
> the same bug.

i don't think it can be done too effectivly in userland..

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgpLDtGz8PDi8.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>