Nathan,
I looked over the edits you made, and most of them are fine.
I did find a couple small things wrong. Despite there small size, they keep
the script from from running correctly.
I also made a change recommended by Ethan.
"cvs diff 068" output below (is that fine, or do you need a unified diff):
Index: 068
===================================================================
RCS file: /cvs/linux-2.4-xfs/cmd/xfstests/068,v
retrieving revision 1.2
diff -r1.2 068
49a50
> mkdir "$tmp"
106c107,110
< [ -e "$SCRATCH_SNAP_MNT" ] && rm -rf "$SCRATCH_SNAP_MNT"
---
> if [ -e "$SCRATCH_SNAP_MNT" ]; then
> rmdir "$SCRATCH_SNAP_MNT" || _notrun "$SCRATCH_SNAP_MNT should be removed
> prior to running."
> fi
>
158c162
< dd if=/dev/zero of=$SCRATCH_MNT/dummy bs=64k count=1000 >/dev/null 2>&1
---
> dd if=/dev/zero of="$SCRATCH_MNT/dummy" bs=64k count=1000 >/dev/null
> 2>&1
210d213
< fi
===================================================================
Line 50: The mkdir is required because $tmp is now a directory to place temp
files in, not a prefix to add an extent to.
Line 107-110: The $SCRATCH_SNAP_MNT change is Ethan's request
Line 162: Some missing quotes requested by Ethan that somehow were missed
previously.
Line 210: An extraneous 'fi' left over from an if statement you converted to
boolean logic. (I don't know how to word this one.)
Greg
========
Greg Freemyer
Internet Engineer
Deployment and Integration Specialist
Compaq ASE - Tru64 v4, v5
Compaq Master ASE - SAN Architect
The Norcross Group
www.NorcrossGroup.com
>> Date: Sun Sep 1 18:39:23 PDT 2002
>> Workarea: snort.melbourne.sgi.com:/home/nathans/sector-xfs
>> The following file(s) were checked into:
>> bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs
>> Modid: 2.4.x-xfs:slinx:126546a
>> linux/fs/xfs/xfs_vnodeops.c - 1.561
>> - remove local tmp variable "sync_mode" which was accidentally
>> left in on previous checkin.
>> Date: Sun Sep 1 23:04:01 PDT 2002
>> Workarea: snort.melbourne.sgi.com:/home/nathans/sector-xfs
>> The following file(s) were checked into:
>> bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs
>> Modid: xfs-cmds:slinx:126551a
>> cmd/xfstests/068 - 1.1
>> cmd/xfstests/068.out - 1.1
>> - A LVM snapshot regression test by Greg Freemyer.
>> cmd/xfstests/group - 1.23
>> - Add in Greg's snapshot test, 068. Also, added 067 back into the
>> auto-qa mix, looks like it wasn't added back after being disabled.
|