xfs
[Top] [All Lists]

Re: [PATCH] Kernel janitor cleanup

To: Keith Owens <kaos@xxxxxxx>
Subject: Re: [PATCH] Kernel janitor cleanup
From: Brian Pontz <brian.pontz@xxxxxxxx>
Date: Mon, 02 Sep 2002 22:20:16 -0400
Cc: linux-xfs@xxxxxxxxxxx
References: <3214.1031018184@xxxxxxxxxxxxxxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.4.1) Gecko/20020508 Netscape6/6.2.3
I was reading the kerneljanitors TODO list at
http://www.kerneljanitors.org/TODO

From: Jeff Garzik <jgarzik at mandrakesoft dot com>

1) "unsigned int" is preferred to "int", it generates better asm code on
all platforms except sh5.  This replacement needs to be done manually,
because often 'int' is required due to negative values -Exxx commonly
passed as error values.

If this is unwanted in the xfs code let me know.

Brian

Keith Owens wrote:

On Mon, 02 Sep 2002 20:28:46 -0400, Brian Pontz <brian.pontz@xxxxxxxx> wrote:

http://www.axehind.com/xfs/xfs-cleanup-1-linux-2.4.patch

The patch is mainly a partial janitor patch.


Given Linus's recent comments about code style, I can understand the
changes from 'return(foo);' to 'return foo;'.  But why change 'int i'
to 'uint i'?




<Prev in Thread] Current Thread [Next in Thread>